Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggested improvements #1

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Some suggested improvements #1

merged 4 commits into from
Sep 23, 2020

Conversation

Schwusch
Copy link
Contributor

  • Removes Flutter as a dependency, making it possible to use in backend projects.
  • Aligns the terminology with the NodeJS library, switching to domain instead of url.
  • Adds passwordGrant, which differs to passwordRealm, not needing a realm.

@Schwusch
Remove flutter dependency
5673281
@Schwusch
Correct serialization
4d80f00
@Schwusch
Add passwordGrant call
118a3af 
- Add clientSecret constructor argument
- Align with NodeJS library on domain/url parameters
@Schwusch
Remove print statement
6ee509b
@mishatron mishatron merged commit 25ce170 into mishatron:master Sep 23, 2020
@mishatron
Copy link
Owner

thanks for contributing. i accept some of your changes. but i want it to use flutter, because my new code has shared preferences. i use it for storing tokens to automaticaly control token refreshing. how can we make it with this logic and available for dart without flutter? can you help me with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishatron mishatron mishatron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Schwusch @mishatron